Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Add Continuous Integration #56

Merged
merged 58 commits into from
Mar 6, 2017
Merged

Add Continuous Integration #56

merged 58 commits into from
Mar 6, 2017

Conversation

mammuth
Copy link
Member

@mammuth mammuth commented Mar 5, 2017

Added Travis as a build server. Static Code analysis is sent to SonarQube. Some stuff will only work after this was merged into master (eg. linting new problems of PR's). Also, I will update the readme with information and instructions when the CI is up for this repo after the merge.

Closes #52

@mammuth mammuth requested a review from TheZoker March 5, 2017 17:36
@kordianbruck kordianbruck requested review from nerdsupremacist and removed request for TheZoker March 5, 2017 17:36
@kordianbruck
Copy link
Member

kordianbruck commented Mar 5, 2017

Please make this a squash and merge when done. We don't need a merge commit here as the history is kinda messy.

@mammuth you can also do this locally on your branch before opening the PR: https://stackoverflow.com/questions/5189560/squash-my-last-x-commits-together-using-git

@mammuth
Copy link
Member Author

mammuth commented Mar 5, 2017

Of course. We just squash it with the shiny new GitHub squash-before-merge-button.

@mammuth
Copy link
Member Author

mammuth commented Mar 5, 2017

@mathiasquintero I also removed the old linked Pods_TUM_Campus_app.framework, and the second referenced group "TUM Campus App" in the last commit, since that led to errors after merging the master back into my branch. As far as I see, those are obsolete?
(That's also the reason why the Travis build failed).

I could imagine that I need some further fine-tuning when the merge is done.

The current tests are not that meaningful right now, I will write some more later (#57)

@mammuth
Copy link
Member Author

mammuth commented Mar 5, 2017

Just for the curious reader:
The build currently fails, because Travis is not exporting the set environment variables to the build machine:

"Travis CI makes encrypted variables and data available only to pull requests coming from the same repository. These are considered trustworthy, as only members with write access to the repository can send them."

https://docs.travis-ci.com/user/pull-requests#Pull-Requests-and-Security-Restrictions
Corresponding open issue: travis-ci/travis-ci#1946

Copy link
Member

@nerdsupremacist nerdsupremacist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh. Fastlane! Fancy!

@mammuth
Copy link
Member Author

mammuth commented Mar 6, 2017

I'm going to squash and merge.

Since there are some changes to the project configuration etc, I checked out this branch into a new directory and tested whether it broke something for "normal" usage (building/running the app); it seems to work. However, if one of you @mathiasquintero or @TheZoker are faced with some issues due to my changes, just drop me a line!

@mammuth mammuth merged commit cf1e694 into TUM-Dev:master Mar 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants